Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Optimizations for Mali with EFB2RAM on #8379

Merged
merged 3 commits into from Oct 31, 2019
Merged

Conversation

@stenzek
Copy link
Contributor

stenzek commented Oct 2, 2019

Using the cached memory type appears to be slower on Mali drivers, with ~10-15% CPU spent in the __pi___inval_cache_range kernel function. This can improve the framerate by up to 30% in some cases.

I also noticed that the Adreno drivers place a coherent+cached heap before the coherent-only heap in the vulkan.gpuinfo.org reports, which the refactoring will handle. I've also set the "slow-cached-memory" bug for Adreno, if anyone has any high-end Adreno devices it'd be interesting to see if it makes any impact there as well.

stenzek added 2 commits Oct 2, 2019
Using the cached memory type appears to be slower on Mali drivers, with
~10-15% CPU spent in the __pi___inval_cache_range kernel function.
@JMC47

This comment has been minimized.

Copy link
Contributor

JMC47 commented Oct 2, 2019

I don't see much of a difference on my snapdragon. It's hard to tell obviously but it seemed to be identical. There was some flickering on transitions that don't happen on master, though.

@stenzek stenzek force-pushed the stenzek:mali branch from 77b64ae to 25fb0e0 Oct 2, 2019
@stenzek stenzek force-pushed the stenzek:mali branch from 25fb0e0 to ecdf21a Oct 2, 2019
@stenzek stenzek removed the needs testing label Oct 31, 2019
@stenzek stenzek merged commit d3ee0a4 into dolphin-emu:master Oct 31, 2019
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@stenzek stenzek deleted the stenzek:mali branch Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.