Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another AVI fix for WinAPI importers #8384

Merged
merged 1 commit into from Oct 6, 2019

Conversation

@vadosnaprimer
Copy link
Contributor

commented Oct 5, 2019

It looks like updated ffmpeg supports 2 versions of ffv1 (1 and 3), but we're not telling it what to use, so in the video it puts 0 if we dump at native resolution, but 3 if we dump at different resolution (not sure why).

I pass ffv1 version explicitly now, and using version 1 allows virtualdub/avisynth and similar VfW-based importers to decode it.

When not using native resolution, FFMPEG automatically selects FFV1 version 3 for whatever reason, and that can't be decoded by VirtualDub/AVISynth.
Copy link
Member

left a comment

Sounds fine. Untested.

@stenzek stenzek merged commit 86bf88d into dolphin-emu:master Oct 6, 2019
8 checks passed
8 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@vadosnaprimer vadosnaprimer deleted the vadosnaprimer:another_avi_fix branch Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.