Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt: Add ability to override ResourcePack and Load directory #8385

Merged
merged 2 commits into from Nov 9, 2019

Conversation

@iwubcode
Copy link
Contributor

iwubcode commented Oct 6, 2019

If you have Dolphin installed on a SSD, you might not want to have giant textures or giant zips installed in your user directory. Instead, you can delegate those folders to be off in another location.

Fixes: https://bugs.dolphin-emu.org/issues/9970

@iwubcode iwubcode force-pushed the iwubcode:pathes-update branch from b52cfd4 to e48aae1 Oct 6, 2019
void PathPane::BrowseLoad()
{
QString dir = QDir::toNativeSeparators(QFileDialog::getExistingDirectory(
this, tr("Select Load Path"), QString::fromStdString(Config::Get(Config::MAIN_LOAD_PATH))));

This comment has been minimized.

Copy link
@BhaaLseN

BhaaLseN Oct 6, 2019

Member

"Load Path" seems a bit generic and nondescript to me (same goes for the setting names etc, btw), I don't suppose we have any more useful names for those?
"Resource pack path" on the other hand clearly tells me what it is.

This comment has been minimized.

Copy link
@iwubcode

iwubcode Oct 6, 2019

Author Contributor

Having a tooltip or something as an explanation would be ideal. The "Load" path is for loading any data (today it is just textures but I already have another review that has different data). I wasn't sure how to summarize it. Maybe "LoadData"?

This comment has been minimized.

Copy link
@BhaaLseN

BhaaLseN Oct 6, 2019

Member

No idea. If I had a suggestion, I'd have included it already.

@@ -18,7 +18,7 @@

namespace ResourcePack
{
constexpr char TEXTURE_PATH[] = "Load/Textures/";
constexpr char TEXTURE_PATH[] = "Textures/";

This comment has been minimized.

Copy link
@Techjar

Techjar Nov 2, 2019

Contributor

If we're following the mnemonic, this should be HIRES_TEXTURES_DIR DIR_SEP. (needs CommonPaths.h)

This comment has been minimized.

Copy link
@iwubcode

iwubcode Nov 2, 2019

Author Contributor

Makes sense. Maybe I'll just remove this variable then?

This comment has been minimized.

Copy link
@Techjar

Techjar Nov 2, 2019

Contributor

Well it is used in several different places, so I dunno.

This comment has been minimized.

Copy link
@iwubcode

iwubcode Nov 2, 2019

Author Contributor

Ah yeah, thought it was only used in two places, looks like three though. I'll keep it

This comment has been minimized.

Copy link
@Techjar

Techjar Nov 2, 2019

Contributor

Perhaps it would make more sense to drop it entirely here and use D_HIRESTEXTURES_IDX in ResourcePackManager.cpp? path only ever has that appended to it in Install and Uninstall anyways.

This comment has been minimized.

Copy link
@iwubcode

iwubcode Nov 2, 2019

Author Contributor

I'm changing that in #8360 so I went with the first option

This comment has been minimized.

Copy link
@Techjar

Techjar Nov 2, 2019

Contributor

Ah, okay makes sense to keep it like this then.

@iwubcode iwubcode force-pushed the iwubcode:pathes-update branch from e48aae1 to 490fd0c Nov 2, 2019
@leoetlino leoetlino merged commit 6cb60f8 into dolphin-emu:master Nov 9, 2019
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@iwubcode iwubcode deleted the iwubcode:pathes-update branch Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.