Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt: When audio backend is invalid, show nothing in dropdown #8392

Merged

Conversation

@JosJuice
Copy link
Contributor

commented Oct 6, 2019

It used to show the first option, No Audio Output (but audio output would work correctly anyway since AudioCommon didn't use this logic.)

It used to show the first option, No Audio Output (but audio output
would work correctly anyway since AudioCommon didn't use this logic.)
@JosJuice JosJuice referenced this pull request Oct 6, 2019
@@ -181,12 +181,18 @@ void AudioPane::LoadSettings()

// Backend
const auto current = SConfig::GetInstance().sBackend;
bool selection_set = false;

This comment has been minimized.

Copy link
@Techjar

Techjar Oct 6, 2019

Contributor

Can we not just set the index to -1 here and be done with it?

This comment has been minimized.

Copy link
@JosJuice

JosJuice Oct 6, 2019

Author Contributor

No, because the act of adding an item (or the act of adding the first item?) sets it back to 0.

This comment has been minimized.

Copy link
@Techjar

Techjar Oct 6, 2019

Contributor

Oh I missed the addItem in the loop.

@stenzek
stenzek approved these changes Oct 7, 2019
@stenzek stenzek merged commit 12b47c9 into dolphin-emu:master Oct 7, 2019
8 checks passed
8 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@JosJuice JosJuice deleted the JosJuice:audio-backend-dropdown-default branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.