Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FifoCI #8397

merged 2 commits into from Oct 9, 2019


Copy link

commented Oct 9, 2019

After #8361 instead of falling back to null sound, it falls back to the ALSA driver on Linux. Which failed on the fifoci runner, which would've been fine except for the fact that the destructor calls std::thread::join without checking if the thread was actually created, which in the case of initialization failing, it wasn't.

Also adds a missing Init() call to the null backend, even though it's a no-op in case it changes in the future.

delroth approved these changes Oct 9, 2019
@stenzek stenzek merged commit 6dbb5cc into dolphin-emu:master Oct 9, 2019
8 checks passed
8 checks passed
default Very basic checks passed, handed off to Buildbot.
lint Build succeeded on builder lint
pr-android Build succeeded on builder pr-android
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
pr-osx-x64 Build succeeded on builder pr-osx-x64
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
pr-win-x64 Build succeeded on builder pr-win-x64
@stenzek stenzek deleted the stenzek:fifoci-fix branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.