Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Game Tracker fixes #8399

merged 3 commits into from Nov 8, 2019


Copy link

CookiePLMonster commented Oct 9, 2019

This PR improves Game Tracker functionality by addressing the following:

  • Fixes a race condition when rapidly clicking Refresh button - previously, game list would continuously be populated over and over, leaving itself in broken state where most entries were duplicated.
  • Enables/disables Refresh button when refresh is already in place. While code technically should support "nested" refresh jobs, I don't know if you can actually end up in such state - maybe if you press Refresh button and use Refresh Game List hotkey at once? No idea.

This PR is generally finished, but I am marking it WIP because I am not satisfied with how it is possible to see "Dolphin could not find any games..." for a split second while refreshing! Ideally, I would like it to just show something like "Refreshing, please wait..."

This resolves a race condition when spamming Refresh button,
which would often end up with duplicates game entries for the entire
duration of the session.
Makes it impossible to spam Refresh button and looks better overall.
@CookiePLMonster CookiePLMonster force-pushed the CookiePLMonster:gametracker-fixes branch from 60286d0 to 68694e0 Oct 19, 2019
@CookiePLMonster CookiePLMonster requested a review from lioncash Oct 19, 2019
@CookiePLMonster CookiePLMonster marked this pull request as ready for review Oct 19, 2019
@CookiePLMonster CookiePLMonster changed the title [WIP] Qt: Game Tracker fixes Qt: Game Tracker fixes Oct 19, 2019

This comment has been minimized.

Copy link
Contributor Author

CookiePLMonster commented Oct 19, 2019

I now added a comment as requested and removed WIP tag, because I figured the issue I mentioned ("Dolphin could not find games...") might as well be treated as a separate bug to fix, as:

  • it happens both with and without this PR
  • it may not be super trivial to fix
@stenzek stenzek merged commit 71b098a into dolphin-emu:master Nov 8, 2019
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
lint Build succeeded on builder lint
pr-android Build succeeded on builder pr-android
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
pr-deb-x64 Build succeeded on builder pr-deb-x64
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
pr-osx-x64 Build succeeded on builder pr-osx-x64
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
pr-win-x64 Build succeeded on builder pr-win-x64
@CookiePLMonster CookiePLMonster deleted the CookiePLMonster:gametracker-fixes branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.