Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignatureDB: Add missing selectors #8400

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@sepalani
Copy link
Contributor

sepalani commented Oct 12, 2019

Fix a DolphinQT regression.

Ready to be reviewed & merged.

@sepalani sepalani force-pushed the sepalani:fix-mega branch from da6ede6 to c54fc4c Oct 12, 2019
@@ -57,6 +57,13 @@

QPointer<MenuBar> MenuBar::s_menu_bar;

const QString MenuBar::GetSignatureSelector() const

This comment has been minimized.

Copy link
@lioncash

lioncash Oct 12, 2019

Member
Suggested change
const QString MenuBar::GetSignatureSelector() const
QString MenuBar::GetSignatureSelector() const

const when returning by value doesn't do anything beneficial (and can even inhibit return value optimizations)

@sepalani sepalani force-pushed the sepalani:fix-mega branch from c54fc4c to 5da7fe4 Oct 12, 2019
@@ -57,6 +57,13 @@

QPointer<MenuBar> MenuBar::s_menu_bar;

QString MenuBar::GetSignatureSelector() const
{
return tr("Dolphin Signature File (*.dsy)") + QStringLiteral(";;") +

This comment has been minimized.

Copy link
@spycrab

spycrab Oct 13, 2019

Contributor
return QStringLiteral("%1 (*.dsy);; %2 (*.csv);; %3 (*.mega)").arg(tr("Dolphin Signature File"), tr("Dolphin Signature CSV File"), tr("WiiTools Signature MEGA File"));

is probably preferable

This comment has been minimized.

Copy link
@sepalani

sepalani Oct 13, 2019

Author Contributor

Done.

@sepalani sepalani force-pushed the sepalani:fix-mega branch from 5da7fe4 to 8dc5557 Oct 13, 2019
@spycrab

This comment has been minimized.

Copy link
Contributor

spycrab commented Oct 13, 2019

LGTM

@spycrab spycrab merged commit 4425d05 into dolphin-emu:master Oct 15, 2019
8 checks passed
8 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@sepalani sepalani deleted the sepalani:fix-mega branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.