Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the names for shader compilation settings #8416

Open
wants to merge 1 commit into
base: master
from

Conversation

@JosJuice
Copy link
Contributor

JosJuice commented Oct 19, 2019

See #8413 (comment)

QT_TR_NOOP("Synchronous (Ubershaders)"),
QT_TR_NOOP("Asynchronous (Ubershaders)"),
QT_TR_NOOP("Asynchronous (Skip Drawing)"),
QT_TR_NOOP("Traditional"),

This comment has been minimized.

Copy link
@blaahaj

blaahaj Oct 19, 2019

I like the other names. But I think 'Traditional' is worse than even 'Synchronous'. 'Synchronous' at least tries to explain it, but 'Traditional' only is meaningful if you know what the Tradition is. If it would be changed back, I would fully approve.

This comment has been minimized.

Copy link
@JosJuice

JosJuice Oct 19, 2019

Author Contributor

I guess reverting just that one to "Synchronous" would make sense in a way... It is the only option that compiles shaders synchronously during normal gameplay, after all. What do others think about this?

This comment has been minimized.

Copy link
@MayImilae

MayImilae Oct 19, 2019

Contributor

From what we discussed in IRC, basically everything is synchronous. Calling one option Synchronous is not accurate, so I'm against that. Traditional works because it is a valid name: it is the traditional method of shader compilation handling in Dolphin and elsewhere.

This comment has been minimized.

Copy link
@JosJuice

JosJuice Oct 19, 2019

Author Contributor

From what we discussed in IRC, basically everything is synchronous.

That was when we were talking about slowdown caused by the GPU performing work. But the options other than this one don't do synchronous shader compilation (disregarding what happens if you change certain settings while the game is running), and shader compilation is exactly what this setting is about, which is why I think synchronous makes sense for this option.

This comment has been minimized.

Copy link
@CookiePLMonster

CookiePLMonster Oct 19, 2019

Contributor

My first thought is that "Standard" would probably be nice - while it's similar to "Traditional", it is more obvious for the user that they are "normal" or "the most regular".

In an emulator like this, I can imagine people thinking "Traditional" is related to classic/retro modes, as in "looking like it used to on a real console and TV back in the day".

This comment has been minimized.

Copy link
@MayImilae

MayImilae Oct 19, 2019

Contributor

"Normal" was the original suggestion, but phire pointed out that it's actually pretty abnormal from a graphics standpooint, it's just the normal for us. Hence, Traditional.

This comment has been minimized.

Copy link
@blaahaj

blaahaj Oct 20, 2019

It can make sense to an emulator programmer. But to reference assumed knowledge is not a substitute for an attempt at actual description.

@JosJuice JosJuice force-pushed the JosJuice:shader-compilation-names branch from a74a85a to a8b5f6d Oct 20, 2019
@leoetlino leoetlino added the RFC label Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.