Coding style clean up for the Jit, JitARM and JitIL #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
force-pushed
the
jit
branch
2 times, most recently
from
5edc151
to
53581b0
Compare
| } | ||
| //grab from list and jump to it | ||
| JMPptr(MComplex(R15, RAX, 8, 0)); | ||
| //IDEA - we have 26 bits, why not just use offsets from base of code? |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| if (isImm(*Op2)) { | ||
| InstLoc IRBuilder::FoldICmpCRSigned(InstLoc Op1, InstLoc Op2) | ||
| { | ||
| if (isImm(*Op1)) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@BhaaLseN Everything look good now? |
|
Good enough for me :) |
lioncash
added a commit
that referenced
this pull request
Aug 21, 2014
Coding style clean up for the Jit, JitARM and JitIL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.