Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmulationActivity: Disable fullscreen immersive after pressing back #8421

Open
wants to merge 1 commit into
base: master
from

Conversation

@phcoder
Copy link

phcoder commented Oct 21, 2019

On Chromebook when in fullscreen immersive I can't open the toolbar.
I'm not sure if I swipe wrong or something but in any case it's not intuitive.
Showing toolbar when pressing back solves te problem neatly

@JosJuice

This comment has been minimized.

Copy link
Contributor

JosJuice commented Oct 21, 2019

I've been considering having the back button just open the menu directly, as a popup rather than a dropdown (and then there'd be a quit option in the menu, unlike now where you press back twice to quit). I think it already works that way on Android TV, but I could be misremembering. Do you think that would make more or less sense than what is in this pull request?

@phcoder

This comment has been minimized.

Copy link
Author

phcoder commented Oct 21, 2019

Yes. Back button opening the menu would solve the problem as well. Any reason not to do it on all Android devices?

On Chromebook when in fullscreen immersive I can't open the toolbar.
I'm not sure if I swipe wrong or something but in any case it's not intuitive.
Showing toolbar when pressing back solves te problem neatly
@phcoder phcoder force-pushed the phcoder:bar branch from 883ee78 to ca28529 Oct 21, 2019
@JosJuice

This comment has been minimized.

Copy link
Contributor

JosJuice commented Oct 21, 2019

No, I'm not aware of any reason.

@leoetlino

This comment has been minimized.

Copy link
Member

leoetlino commented Nov 8, 2019

What's the status of this PR? Do you intend to make the back button open the menu?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.