Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create necessary folder when using Redump.org integration #8429

Merged
merged 2 commits into from Oct 26, 2019

Conversation

@JosJuice
Copy link
Contributor

JosJuice commented Oct 25, 2019

This was making it impossible to use the Redump.org integration without first manually creating a Redump folder in the Cache folder. https://bugs.dolphin-emu.org/issues/11885

This was making it impossible to use the Redump.org integration
without first manually creating a Redump folder in the Cache folder.
https://bugs.dolphin-emu.org/issues/11885
@BhaaLseN

This comment has been minimized.

Copy link
Member

BhaaLseN commented Oct 25, 2019

Should we really be returning DownloadStatus::Success when writing the file failed?

@JosJuice

This comment has been minimized.

Copy link
Contributor Author

JosJuice commented Oct 25, 2019

That's probably not perfect... But returning DownloadStatus::Fail instead would make the GUI display "Failed to connect to Redump.org", which isn't true. So I'm not sure if there's a good solution for this unless we want to add an extra translatable string for the hopefully uncommon cases of folder permissions being messed up or the disk being full.

@xerxespersrex

This comment has been minimized.

Copy link

xerxespersrex commented Oct 25, 2019

This PR solves issue 11885 for me. For Linux, it makes the folder in ~/.local/share/dolphin-emu/Cache/Redump/ though instead of ~/.cache/dolphin-emu/, don't know if that was intentional (the Cache folder in share is created only for this PR and it otherwise doesn't exist).

@JosJuice

This comment has been minimized.

Copy link
Contributor Author

JosJuice commented Oct 25, 2019

Thanks for catching that – it should be fixed by the commit I just pushed.

@xerxespersrex

This comment has been minimized.

Copy link

xerxespersrex commented Oct 25, 2019

Yep, everything works perfectly now for me, it's created in ~/.cache/dolphin-emu/Redump/ like it should be and verification works fine.

@lioncash lioncash merged commit 427d450 into dolphin-emu:master Oct 26, 2019
7 checks passed
7 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@JosJuice JosJuice deleted the JosJuice:redump-create-path branch Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.