Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt: Call OnEmulationStateChanged when creating config window panes #8433

Merged

Conversation

@JosJuice
Copy link
Contributor

JosJuice commented Oct 26, 2019

Otherwise UI elements won't be disabled correctly if the config window is first opened while a game is running.

…anes

Otherwise UI elements won't be disabled correctly if the config
window is first opened while a game is running.
@Techjar

This comment has been minimized.

Copy link
Contributor

Techjar commented Oct 26, 2019

This seems like a hacky workaround. OnEmulationStateChanged should only be called when the state actually changes. Couldn't calling it under other circumstances potentially have some side effects?

Nevermind, I misunderstood OnEmulationStateChanged as the signal itself, but it's just the function in the Qt object that actually does the work.

@JosJuice

This comment has been minimized.

Copy link
Contributor Author

JosJuice commented Oct 26, 2019

The OnEmulationStateChanged functions in these files have no side effects that we want to avoid. All they do is enable or disable UI elements based on the argument.

@JosJuice JosJuice force-pushed the JosJuice:settings-onemulationstatechanged branch from c9c31aa to 10d9727 Oct 27, 2019
@stenzek stenzek merged commit 2ebea1b into dolphin-emu:master Nov 8, 2019
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@JosJuice JosJuice deleted the JosJuice:settings-onemulationstatechanged branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.