Changed unsigned ints and chars to cstdint counterparts #845
Conversation
crozhon
force-pushed
the
switch_to_cstdint
branch
from
9de4147
to
9d0d836
Compare
crozhon
force-pushed
the
switch_to_cstdint
branch
from
9d0d836
to
d84b2f3
Compare
|
@dolphin-emu-bot rebuild |
|
... that's not cstdint? |
|
I think what he meant is that our CommonTypes typedefs utilize the cstdint types as a base, so it's sort of equivalent (albeit ambiguous) |
|
That is what I meant. |
|
The typedefs seem completely unnecessary since they are only used in one other place. It seems better to just use our CommonTypes typedefs. |
|
This naming is used because the structs are copied from the real ELF support library. |
|
@shuffle2 so should the type names be kept? As far as I see, it just adds more noise to the code since it adds more typedefs elsewhere for the same thing. |
|
I guess it doesn't matter one way or the other, just mentioning the reasoning. |
|
Oh ok. |
|
@dolphin-emu-bot rebuild |
|
Aww, now the Elf(32)_Sword is no more! ;( |
|
@ChuckRozhon: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge. Not really a big fan since this is basically external code - but I can understand the reasoning and I'm not completely opposed to it. @dolphin-emu-bot allowmerge |
Changed unsigned ints and chars to cstdint counterparts
No description provided.