Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt: Hide unused buttons in the advanced mapping dialog. #8459

Merged
merged 1 commit into from Nov 9, 2019

Conversation

@jordan-woyak
Copy link
Member

jordan-woyak commented Nov 8, 2019

Fix regression from #8396.

Some widgets are conditionally added to the layout.

The unused ones were showing up in the top-left corner.

This hides the unused widgets.

Copy link
Contributor

iwubcode left a comment

Code looked fine and I can confirm there's no "test" button showing for input.

@BhaaLseN

This comment has been minimized.

Copy link
Member

BhaaLseN commented Nov 9, 2019

Why do we even add them in first place if we dont use/need them?

@jordan-woyak

This comment has been minimized.

Copy link
Member Author

jordan-woyak commented Nov 9, 2019

Why do we even add them in first place if we dont use/need them?

The widgets are referenced elsewhere and assumed to exist.
I think this is cleaner than throwing more "is input" checks throughout the code.

@leoetlino leoetlino merged commit 877519a into dolphin-emu:master Nov 9, 2019
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@jordan-woyak jordan-woyak deleted the jordan-woyak:io-window-button-fix branch Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.