Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Update target Android SdkVersion to 28 #8461

Open
wants to merge 1 commit into
base: master
from

Conversation

@Simonx22
Copy link
Contributor

Simonx22 commented Nov 9, 2019

Since 11/01/2019, Android requires SDK version 28 (aka Android 9). If you submit an update with SDK version 27 and below, Google will reject the update. Read more here: https://android-developers.googleblog.com/2019/02/expanding-target-api-level-requirements.html

I have tested this change on my phone and haven't encountered any issues.

@Simonx22 Simonx22 changed the title Android: Update target Android SdkVersion to 28 Android: Update target Android SdkVersion to 29 Nov 9, 2019
@Simonx22 Simonx22 force-pushed the Simonx22:SdkVersion branch from eef84b9 to 70b7c5b Nov 9, 2019
@Simonx22

This comment has been minimized.

Copy link
Contributor Author

Simonx22 commented Nov 9, 2019

Apparently Google recommends to migrate to AndroidX... I will look into that.

@Simonx22

This comment has been minimized.

Copy link
Contributor Author

Simonx22 commented Nov 9, 2019

Done. I've tested this change on my phone and it works fine.

@Techjar

This comment has been minimized.

Copy link
Contributor

Techjar commented Nov 9, 2019

That should probably be a separate PR.

@Simonx22 Simonx22 force-pushed the Simonx22:SdkVersion branch from cf29275 to 70b7c5b Nov 9, 2019
@Simonx22

This comment has been minimized.

Copy link
Contributor Author

Simonx22 commented Nov 9, 2019

Makes sense. I will migrate to AndroidX after this commit has been merged.

@mbc07

This comment has been minimized.

Copy link
Contributor

mbc07 commented Nov 9, 2019

Have you made sure storage-related functions still work? Scoped Storage was giving a lot of headaches for existing apps, although I haven't checked if the behavior changed once the final build of Android 10 got released...

@Simonx22

This comment has been minimized.

Copy link
Contributor Author

Simonx22 commented Nov 9, 2019

I can't really test scoped storage since I only have a device with Android 9 and the Android emulator doesn't seem to like Dolphin for whatever reason. Maybe someone else can test. Otherwise, I could go back to SDK version 28 for now which is the current minimum for the Play Store until sometime in 2020.

@mbc07

This comment has been minimized.

Copy link
Contributor

mbc07 commented Nov 9, 2019

Otherwise, I could go back to SDK version 28 for now which is the current minimum for the Play Store until sometime in 2020

Yep, that sounds more reasonable and give us time to properly check this as I don't think it's a good idea to jump to targetSDK 29 until someone can confirm scoped storage doesn't impact us negatively...

@Simonx22 Simonx22 force-pushed the Simonx22:SdkVersion branch from 70b7c5b to be48944 Nov 9, 2019
@Simonx22 Simonx22 changed the title Android: Update target Android SdkVersion to 29 Android: Update target Android SdkVersion to 28 Nov 9, 2019
@Simonx22

This comment has been minimized.

Copy link
Contributor Author

Simonx22 commented Nov 9, 2019

I agree. I've reverted to 28 now. Can someone make the buildbot accept the licenses and then make it run on this PR?

Copy link
Contributor

JosJuice left a comment

LGTM with SDK 28 (not SDK 29).

For what it's worth, there's already PR #7864, but I'm not going to close this one in favor of that one since the other one currently has merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.