Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shader precompilation interruptable #8467

Open

Conversation

@CookiePLMonster
Copy link
Contributor

CookiePLMonster commented Nov 10, 2019

This PR refactors shader precompilation ("Compile shaders before starting") to be interruptable. Previously, user was unable to close emulation gracefully during that step and had to either wait or forcibly terminate the process.

Additionally, UI window will now clear after finishing or aborting shader precompilation - so ImGui's message box will not linger until game renders something.

…ilation
@8times9

This comment has been minimized.

Copy link
Contributor

8times9 commented Nov 11, 2019

@CookiePLMonster

This comment has been minimized.

Copy link
Contributor Author

CookiePLMonster commented Nov 11, 2019

@stenzek left comments on this ticket so I think he's the most appropriate person to review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.