Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msvc: skip copying Data dir and precompiled dlls to Binary dir if they are already there (unless the source files are newer). #848

Merged
merged 1 commit into from Aug 21, 2014

Conversation

shuffle2
Copy link
Contributor

Since the move to VS2013, the Data directory was unconditionally copied to the Binary directory each time the DolphinWX project was built. Previously, xcopy was used, and only copied files if the version in the Data/ was newer than the one in the Binary/. This restores that behavior. Practically, this means that gameini files aren't overwritten if you have local changes.

…y are already there (unless the source files are newer).

Also fix a bug which was preventing DolphinWX/AfterBuild target from being completely skipped.
@Parlane
Copy link
Member

Parlane commented Aug 21, 2014

@dolphin-emu-bot rebuild

@lioncash
Copy link
Member

looks gr8 m8

@Parlane
Copy link
Member

Parlane commented Aug 21, 2014

LGTM

Parlane added a commit that referenced this pull request Aug 21, 2014
msvc: skip copying Data dir and precompiled dlls to Binary dir if they are already there (unless the source files are newer).
@Parlane Parlane merged commit cf82972 into dolphin-emu:master Aug 21, 2014
@shuffle2 shuffle2 deleted the msvc-improvements branch August 21, 2014 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants