Update VS projects/solutions to VS2019 #8498
Merged
+109
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Nov 27, 2019
stenzek
force-pushed
the
update-vs2019
branch
2 times, most recently
from
b9ee09a
to
f2ff456
Compare
BhaaLseN
approved these changes
Nov 27, 2019
They're all in the Qt headers, and quite noisy.
stenzek
force-pushed
the
update-vs2019
branch
from
f2ff456
to
33c0abd
Compare
|
Unless anyone has any objections, I'll go ahead and merge the update. Will wait a couple more days until doing so. |
leoetlino
added a commit
to leoetlino/sadm
that referenced
this pull request
Apr 17, 2021
Finishes the CMake migration. Unlike dolphin-emu#113 (the previous attempt), this PR takes a different approach. Instead of assuming that the compiler and environment variables are already set, we call the vcvars64.bat batch script to find the WinSDK, compiler path, include paths, etc. and to set any environment variables that are required to compile. This should require less maintenance than the previous approach. The only time we have to change something in the buildbot config file is when we upgrade to a new major version of Visual Studio. One concern that was raised last time is that the WinSDK version is not pinned so we end up using the latest WinSDK version. However, since dolphin-emu/dolphin#8498 was merged, the VS project files also do the exact same thing, and minimum version checks have been added elsewhere to ensure the WinSDK version isn't too old. Anyway, with this approach, if we ever need to use a specific version of the Windows SDK, we can easily switch to vcvarsall.bat later on: https://docs.microsoft.com/en-us/cpp/build/building-on-the-command-line?view=msvc-160#vcvarsall-syntax So I don't think this should be a blocker. I've tested the build steps I added in a Windows VM, but this needs some testing to make sure e.g. incremental builds work fine.
leoetlino
added a commit
to leoetlino/sadm
that referenced
this pull request
Apr 19, 2021
Finishes the CMake migration. Unlike dolphin-emu#113 (the previous attempt), this PR takes a different approach. Instead of assuming that the compiler and environment variables are already set, we call the vcvars64.bat batch script to find the WinSDK, compiler path, include paths, etc. and to set any environment variables that are required to compile. This should require less maintenance than the previous approach. The only time we have to change something in the buildbot config file is when we upgrade to a new major version of Visual Studio. One concern that was raised last time is that the WinSDK version is not pinned so we end up using the latest WinSDK version. However, since dolphin-emu/dolphin#8498 was merged, the VS project files also do the exact same thing, and minimum version checks have been added elsewhere to ensure the WinSDK version isn't too old. Anyway, with this approach, if we ever need to use a specific version of the Windows SDK, we can easily switch to vcvarsall.bat later on: https://docs.microsoft.com/en-us/cpp/build/building-on-the-command-line?view=msvc-160#vcvarsall-syntax So I don't think this should be a blocker. I've tested the build steps I added in a Windows VM, but this needs some testing to make sure e.g. incremental builds work fine.
leoetlino
added a commit
to leoetlino/sadm
that referenced
this pull request
Apr 24, 2021
Finishes the CMake migration. Unlike dolphin-emu#113 (the previous attempt), this PR takes a different approach. Instead of assuming that the compiler and environment variables are already set, we call the vcvars64.bat batch script to find the WinSDK, compiler path, include paths, etc. and to set any environment variables that are required to compile. This should require less maintenance than the previous approach. The only time we have to change something in the buildbot config file is when we upgrade to a new major version of Visual Studio. One concern that was raised last time is that the WinSDK version is not pinned so we end up using the latest WinSDK version. However, since dolphin-emu/dolphin#8498 was merged, the VS project files also do the exact same thing, and minimum version checks have been added elsewhere to ensure the WinSDK version isn't too old. Anyway, with this approach, if we ever need to use a specific version of the Windows SDK, we can easily switch to vcvarsall.bat later on: https://docs.microsoft.com/en-us/cpp/build/building-on-the-command-line?view=msvc-160#vcvarsall-syntax So I don't think this should be a blocker. I've tested the build steps I added in a Windows VM, but this needs some testing to make sure e.g. incremental builds work fine.
leoetlino
added a commit
to leoetlino/sadm
that referenced
this pull request
Apr 25, 2021
Finishes the CMake migration. Unlike dolphin-emu#113 (the previous attempt), this PR takes a different approach. Instead of assuming that the compiler and environment variables are already set, we call the vcvars64.bat batch script to find the WinSDK, compiler path, include paths, etc. and to set any environment variables that are required to compile. This should require less maintenance than the previous approach. The only time we have to change something in the buildbot config file is when we upgrade to a new major version of Visual Studio. One concern that was raised last time is that the WinSDK version is not pinned so we end up using the latest WinSDK version. However, since dolphin-emu/dolphin#8498 was merged, the VS project files also do the exact same thing, and minimum version checks have been added elsewhere to ensure the WinSDK version isn't too old. Anyway, with this approach, if we ever need to use a specific version of the Windows SDK, we can easily switch to vcvarsall.bat later on: https://docs.microsoft.com/en-us/cpp/build/building-on-the-command-line?view=msvc-160#vcvarsall-syntax So I don't think this should be a blocker.
leoetlino
added a commit
to leoetlino/sadm
that referenced
this pull request
May 24, 2021
Finishes the CMake migration. Unlike dolphin-emu#113 (the previous attempt), this PR takes a different approach. Instead of assuming that the compiler and environment variables are already set, we call the vcvars64.bat batch script to find the WinSDK, compiler path, include paths, etc. and to set any environment variables that are required to compile. This should require less maintenance than the previous approach. The only time we have to change something in the buildbot config file is when we upgrade to a new major version of Visual Studio. One concern that was raised last time is that the WinSDK version is not pinned so we end up using the latest WinSDK version. However, since dolphin-emu/dolphin#8498 was merged, the VS project files also do the exact same thing, and minimum version checks have been added elsewhere to ensure the WinSDK version isn't too old. Anyway, with this approach, if we ever need to use a specific version of the Windows SDK, we can easily switch to vcvarsall.bat later on: https://docs.microsoft.com/en-us/cpp/build/building-on-the-command-line?view=msvc-160#vcvarsall-syntax So I don't think this should be a blocker.
so i cannot install VS2019 is it possible to use the older one on my end? |
|
No, you need VS2019 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What the title says. The buildbots were updated a while back, so I don't see much reason to stay on the old toolset.
I'm assuming the plan is still to migrate to cmake, but at least we'll discover any issues with the new compiler this way, changing one thing a time?