Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VS projects/solutions to VS2019 #8498

Merged
merged 3 commits into from Dec 3, 2019
Merged

Conversation

@stenzek
Copy link
Contributor

stenzek commented Nov 27, 2019

What the title says. The buildbots were updated a while back, so I don't see much reason to stay on the old toolset.

I'm assuming the plan is still to migrate to cmake, but at least we'll discover any issues with the new compiler this way, changing one thing a time?

Source/VSProps/Base.props Outdated Show resolved Hide resolved
@stenzek stenzek force-pushed the stenzek:update-vs2019 branch 2 times, most recently from b9ee09a to f2ff456 Nov 27, 2019
Copy link
Member

BhaaLseN left a comment

Seems good in general. Saw it only after commenting on the ARM one, so those comments are probably ignorable over there.

Source/Core/DolphinQt/DolphinQt.vcxproj Outdated Show resolved Hide resolved
@stenzek stenzek force-pushed the stenzek:update-vs2019 branch from f2ff456 to 33c0abd Nov 30, 2019
@stenzek

This comment has been minimized.

Copy link
Contributor Author

stenzek commented Nov 30, 2019

Unless anyone has any objections, I'll go ahead and merge the update. Will wait a couple more days until doing so.

@stenzek stenzek merged commit 15fc71c into dolphin-emu:master Dec 3, 2019
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@stenzek stenzek deleted the stenzek:update-vs2019 branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.