Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPCCache: Make arrays constexpr where applicable #8506

Open
wants to merge 2 commits into
base: master
from

Conversation

@lioncash
Copy link
Member

lioncash commented Dec 3, 2019

We make use of std::array within the PPC cache code. While we're in there, we can make the initialization of two arrays constexpr and move them out of the save state data, shrinking the size of save states a little bits.

@lioncash lioncash force-pushed the lioncash:cache branch from 607fd6a to b0d1aca Dec 3, 2019
data = {};
tags = {};
Comment on lines 106 to 107

This comment has been minimized.

Copy link
@CookiePLMonster

CookiePLMonster Dec 3, 2019

Contributor

You used fill in InstructionCache::Reset, why not here too?

lioncash added 2 commits Dec 3, 2019
Allows simplifying a bunch of initialization and filling code.
Two of these arrays were stored within the save state when the exact
same data is constructed all the time.

We can just build this into the binary rather than the save state,
shrinking a little bit of the save state's overall size.
@lioncash lioncash force-pushed the lioncash:cache branch from b0d1aca to 474e210 Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.