Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt: Properly hide Wii remote extension motion tabs when no extension is selected. #8559

Merged
merged 1 commit into from Jan 14, 2020

Conversation

@jordan-woyak
Copy link
Member

jordan-woyak commented Jan 14, 2020

When opening the dialog with extension set to "None" the tabs were incorrectly shown.
The tabs should only be shown when "Nunchuk" is selected (which triggers an event that unhides the tabs).

…ension is selected.
@jordan-woyak jordan-woyak force-pushed the jordan-woyak:nunchuk-tabs-fix branch from 61b5ea3 to f5d9b78 Jan 14, 2020
Copy link
Contributor

rlnilsen left a comment

How did I miss this? :-(

@JMC47 JMC47 merged commit 9596fe7 into dolphin-emu:master Jan 14, 2020
9 of 10 checks passed
9 of 10 checks passed
pr-osx-x64 Build failed on builder pr-osx-x64
Details
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@jordan-woyak jordan-woyak deleted the jordan-woyak:nunchuk-tabs-fix branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.