Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always display the horizontal scroll bar when log word wrap is off #8565

Open
wants to merge 1 commit into
base: master
from

Conversation

@Pokechu22
Copy link
Contributor

Pokechu22 commented Jan 15, 2020

Otherwise, a line that's too wide for the log widget will cause the horizontal scroll bar to appear, which reduces the vertical height, and causes the most recent line to be off screen. Since that line is off screen, the log widget no longer scrolls as new lines appear, unless it's manually scrolled to the very bottom again.

Otherwise, a line that's too wide for the log widget will cause the horizontal scroll bar to appear, which reduces the vertical height, and causes the most recent line to be off screen.  Since that line is off screen, the log widget no longer scrolls as new lines appear, unless it's manually scrolled to the very bottom again.
@shuffle2

This comment has been minimized.

Copy link
Contributor

shuffle2 commented Jan 20, 2020

This seems like behavior all users of Qt would have to deal with.
A few threads suggest manually moving the vertical scroll after each append.
(here's an example) https://www.qtcentre.org/threads/5983-QTextEdit-auto-scroll?s=2a1fa9396c24cb72ebed58177c9d79a7&p=31003#post31003

@Pokechu22

This comment has been minimized.

Copy link
Contributor Author

Pokechu22 commented Jan 20, 2020

It already does autoscroll (as far as I can tell, without any manual intervention on Dolphin's behalf; perhaps Qt changed since that thread was created in 2007). This PR just fixes a case where the autoscroll can break.

@shuffle2

This comment has been minimized.

Copy link
Contributor

shuffle2 commented Jan 20, 2020

yes, but i think manually scrolling to the end after lines are pushed would be a better fix for this issue. worth trying at least?

@Pokechu22

This comment has been minimized.

Copy link
Contributor Author

Pokechu22 commented Jan 20, 2020

There is a difference — the current automatic scrolling behavior Qt gives allows following the log, but scrolling up to look at older output at which point it'll auto-scrolling until it's scrolled to the end again. Force-scrolling to the end would break that (and if that is done, I'd want a checkbox to disable it, but that'd mean also disabling the Qt auto-scrolling when it's unchecked which I'm not is even possible).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.