VideoCommon/TextureConversionShader: Convert over to using ShaderCode #8576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrates the shader generator off the use of a global array, eliminating the use of some global state. This also allows us to move the shader generation over to using fmt in a subsequent change.
Now that we've converted the shader generation over to ShaderCode, we can now make use of the fmt-capable WriteFmt function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Previously the shader generation used a global text buffer to contain the generated text and then returned a pointer into the buffer. This was what a few of the other shader generators used to do until
ShaderCodewas introduced.We can convert this over to use
ShaderCodeto make it consistent with the other generators and then convert it over to making use of the fmt-capableWriteFmt. I've done this in two parts to make it easier to review the initial conversion over toShaderCodeand the subsequent conversion over to making use of fmt.