Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme.md Tweak Command Line section #8583

Open
wants to merge 1 commit into
base: master
from

Conversation

@Craftyawesome
Copy link
Contributor

Craftyawesome commented Jan 25, 2020

Adds newer backends to readme + more positive about hle accuracy.

The command list itelf is still outdated, though.

Readme.md Outdated
@@ -141,12 +141,13 @@ see where it's stored) if you don't plan to reinstall Dolphin.
* -A, --audio_emulation=<str> Low level (LLE) or high level (HLE) audio

Available DSP emulation engines are HLE (High Level Emulation) and
LLE (Low Level Emulation). HLE is fast but often less accurate while LLE is
LLE (Low Level Emulation). HLE is fast but can be less accurate while LLE is

This comment has been minimized.

Copy link
@jordan-woyak

jordan-woyak Jan 25, 2020

Member

I think "often" is still a better word here.

This comment has been minimized.

Copy link
@Craftyawesome

Craftyawesome Jan 25, 2020

Author Contributor

Is HLE incorrect enough to be "often" less accurate than LLE, though?
Maybe something like

Suggested change
LLE (Low Level Emulation). HLE is fast but can be less accurate while LLE is
LLE (Low Level Emulation). HLE is fast but is less accurate than LLE, which is
Readme.md Outdated Show resolved Hide resolved
Copy link
Member

leoetlino left a comment

LGTM, but please squash your commits

@Craftyawesome Craftyawesome force-pushed the Craftyawesome:readme-updates branch from 9c34658 to 62046d9 Feb 16, 2020
@Craftyawesome Craftyawesome reopened this Feb 16, 2020
@Rukario

This comment has been minimized.

Copy link
Contributor

Rukario commented Feb 17, 2020

It'd probably read better with less use of the word "which",

"HLE is faster but less accurate whereas LLE is slower but close to perfect. Note that LLE has two submodes (Interpreter and Recompiler) but they cannot be selected from the command line."

And then

"Available video backends are "D3D" and "D3D12" (they are only available on Windows), "OGL", and "Vulkan"."

It reads better with an "and" instead of comma for the D3D modes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.