DolphinQt: Remove unimplemented function prototypes #8588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't implemented anywhere, so the prototype can be removed.
…ifdef This is only used on Apple and Unix-like machines, so we can enclose the prototype with an ifdef like the implementation is. This prevents false-positives about an unimplemented function prototype.
…unction This isn't implemented anywhere, so we can remove this prototype.
…ber function This isn't implemented anywhere, so we can remove the member function prototype.
jordan-woyak
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Removes three unimplemented function prototypes and also surrounds
OnSignal()within MainWindow with a relevant ifdef (like its implementation is), so that it's not mistakenly considered an unimplemented function prototype on Windows.