DolphinQt/GCMemcardManager: Mark string as translatable within GetErrorMessagesForErrorCode() #8589
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orMessagesForErrorCode() This is a string that can potentially be seen by a user, so it should be marked as translatable, like the other strings are.
…ssagesForErrorCode() Same behavior, but eliminates the use of a program lifetime Qt string literal.
jordan-woyak
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is a string that can potentially be seen by a user, so it should be marked as translatable like the other strings are.
While we're in the same area, we can also make use of
QLatin1Charinstead ofQStringLiteralin the followingjoin()call. It provides the same behavior, but without the need for program-lifetime QString data.