New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DiscIO: Implement re-encryption of Wii partition data #8591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff91ccd
to
9a67850
Compare
lioncash
reviewed
Jan 28, 2020
9a67850
to
8d598ec
Compare
BhaaLseN
reviewed
Jan 28, 2020
leoetlino
reviewed
Jan 28, 2020
8411993
to
48abcbc
Compare
7056353
to
0bc978a
Compare
degasus
reviewed
Apr 24, 2020
degasus
reviewed
Apr 24, 2020
degasus
reviewed
Apr 24, 2020
degasus
approved these changes
Apr 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments remaining, but overall LGTM
Instead of the partition offset (which is usually 0x20000 less).
998743f
to
8b98b7f
Compare
8b98b7f
to
432f342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This was originally created as part of the WIA PR, but since it also is useful for DirectoryBlob, I'm submitting it as a separate PR. (Not that the accuracy improvement will matter for emulated software other than CleanRip unless you disable
VolumeWii'sReadWiiDecryptedcode path...)