Vulkan: Treat VK_SUBOPTIMAL_KHR as VK_SUCCESS on Android #8595
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may help us debug performance problems in the future.
Android 10 seems to expect a prerotated/transformed swap chain for optimal presentation. For now, until we implement that, just ignore the hint.
stenzek
force-pushed
the
android-10-vulkan-suboptimal
branch
from
e8df94a
to
08cc731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Android 10 seems to expect a prerotated/transformed swap chain for optimal presentation. For now, until we implement that, just ignore the hint.
See: https://twitter.com/Themaister/status/1207062674011574273
This was causing us to recreate the swap chain every frame, with an identity pretransform which would return suboptimal for the next presentation, repeat. Hence performance loss, since it's not cheap. I'm surprised the hit wasn't higher to be honest.
Fixes https://bugs.dolphin-emu.org/issues/11946