DolphinQt/Mapping: Tweak "Dead Zone" and "Gate" colors. #8603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tte to a transparent black or white depending on theme. Tweak order of "shake" indicator axis colors so red is more often shown.
iwubcode
reviewed
Feb 5, 2020
iwubcode
approved these changes
Feb 5, 2020
|
Looks good to me! Also, here are some macOS screenshots if you are curious! The dark theme is ignored by Dolphin in macOS so, only the normal light theme for this. Before: After: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed "dead zone" color to a transparent black or white depending on theme.
Inverted value of "gate" colors when active theme has a dark background.
Tweaked order of "shake" indicator axis colors so red is more often shown.
Indicators now look less horrible with dark themes and the dead zone is more subtle as it should be.
Before:
https://i.imgur.com/aUriQaT.png
https://i.imgur.com/aHCSYCj.png
After:
https://i.imgur.com/cWZu4IS.png
https://i.imgur.com/JR8anBW.png