Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt/Mapping: Tweak "Dead Zone" and "Gate" colors. #8603

Merged
merged 1 commit into from Feb 10, 2020

Conversation

@jordan-woyak
Copy link
Member

jordan-woyak commented Feb 4, 2020

Changed "dead zone" color to a transparent black or white depending on theme.
Inverted value of "gate" colors when active theme has a dark background.
Tweaked order of "shake" indicator axis colors so red is more often shown.

Indicators now look less horrible with dark themes and the dead zone is more subtle as it should be.

Before:
https://i.imgur.com/aUriQaT.png
https://i.imgur.com/aHCSYCj.png

After:
https://i.imgur.com/cWZu4IS.png
https://i.imgur.com/JR8anBW.png

…tte to a transparent black or white depending on theme. Tweak order of "shake" indicator axis colors so red is more often shown.
Copy link
Contributor

iwubcode left a comment

Code looks good! Untested though. From the screenshots I think the light theme is an improvement. Not big on dark-themes so someone else will need to comment on that.

@MayImilae

This comment has been minimized.

Copy link
Contributor

MayImilae commented Feb 10, 2020

Looks good to me! Also, here are some macOS screenshots if you are curious! The dark theme is ignored by Dolphin in macOS so, only the normal light theme for this.

Before:
Screen Shot 2020-02-10 at 04 23 44

After:
Screen Shot 2020-02-10 at 04 25 42

@Tilka Tilka merged commit a9dc4ac into dolphin-emu:master Feb 10, 2020
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@jordan-woyak jordan-woyak deleted the jordan-woyak:deadzone-too-dark branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.