Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt: Give hotkeys their own "background input" setting. #8609

Open
wants to merge 1 commit into
base: master
from

Conversation

@jordan-woyak
Copy link
Member

jordan-woyak commented Feb 8, 2020

Setting is named "Hotkeys Require Window Focus".
Please give opinions on the naming in the UI+INI and whether the checked state should be enabled or disabled.
image
Fixes: https://bugs.dolphin-emu.org/issues/8262

@MayImilae

This comment has been minimized.

Copy link
Contributor

MayImilae commented Feb 10, 2020

I think the naming of this is pretty good. It says exactly what it does and it is very clear.

Btw, if this default on or off?

@jordan-woyak

This comment has been minimized.

Copy link
Member Author

jordan-woyak commented Feb 10, 2020

The setting is enabled by default.

@jordan-woyak jordan-woyak force-pushed the jordan-woyak:separate-hotkey-background-input branch from b7d8a65 to 903db48 Feb 11, 2020
@Techjar

This comment has been minimized.

Copy link
Contributor

Techjar commented Feb 11, 2020

LGTM. Not sure I like the setting in the User Interface pane though, maybe move it to Render Window?

@jordan-woyak

This comment has been minimized.

Copy link
Member Author

jordan-woyak commented Feb 11, 2020

LGTM. Not sure I like the setting in the User Interface pane though, maybe move it to Render Window?

I don't think "Render Window" makes sense. This setting applies even when games aren't running.

@Techjar

This comment has been minimized.

Copy link
Contributor

Techjar commented Feb 11, 2020

Ah, fair enough I guess.

@AdmiralCurtiss

This comment has been minimized.

Copy link
Contributor

AdmiralCurtiss commented Feb 13, 2020

It seems this only considers the render window when checking for focus, which is very impractical for things like the debugger.

@jordan-woyak

This comment has been minimized.

Copy link
Member Author

jordan-woyak commented Feb 13, 2020

@AdmiralCurtiss The window focus logic was already in place. This PR just exposes a separate "Background Input" setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.