Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW/WiimoteEmu: Allow emulating the "Classic Controller Pro". #8611

Open
wants to merge 1 commit into
base: master
from

Conversation

@jordan-woyak
Copy link
Member

jordan-woyak commented Feb 8, 2020

The "Pro" version does not have analog triggers.
Apparently some games are aware of this and change their controls.
The mapping indicator changes appropriately when enabled.
image
Setting name good as just "Classic Controller Pro" ?

@mbc07

This comment has been minimized.

Copy link
Contributor

mbc07 commented Feb 8, 2020

I think all controls except for L and R should be changed to disabled state when the user mark the "Classic Controller Pro" checkbox. Perhaps also add a tooltip when hovering the "Classic Controller Pro" saying that the Pro lacks analog triggers. Other than that LGTM...

@iwubcode

This comment has been minimized.

Copy link
Contributor

iwubcode commented Feb 8, 2020

Apparently some games are aware of this and change their controls.

Haven't gone through the code yet but which games have this behavior? Just curious!

@jordan-woyak

This comment has been minimized.

Copy link
Member Author

jordan-woyak commented Feb 8, 2020

@iwubcode Apparently 007 Goldeneye, according to https://strategywiki.org/wiki/GoldenEye_007_(2010)/Controls#Classic_Controller_Style
But my testing is showing otherwise.
Now I'm not sure...

@mbc07

This comment has been minimized.

Copy link
Contributor

mbc07 commented Feb 8, 2020

I think being able to emulate a Classic Controller or a Classic Controller Pro is a worthy addition just for the sake of emulating all Wiimote extensions, even if no commercial game actually makes a distinction between them...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.