Config: Expose "DisableScreenSaver" in the UI and default it to true. #8613
Conversation
|
|
|
I assume this also inhibits power saving modes such as turning off the display and sleep? Also, does this only apply while a game is running, or always if Dolphin is running? |
Depends on the platform.
Only while a game is running. Need to clarify the wording imo. |
|
An issue that I often have on Windows 10 is that while Dolphin prevents the screen from turning off and the computer from entering sleep mode when this option is enabled, if you're playing exclusively with controllers, the Windows 10 Lock Screen will still come up after sometime, and when that happens it generally also makes Dolphin exit fullscreen mode. Does this PR do anything to improve on that (e.g. preventing also the lock screen) or it just exposes the existing option with the existing behavior in the GUI? |
|
@mbc07 This just exposes the existing option. |
|
What about a more commonly-used verb like "Prevent Screen Saver While Running"? |
| @@ -151,11 +152,13 @@ void InterfacePane::CreateUI() | |||
| m_checkbox_use_covers = | |||
| new QCheckBox(tr("Download Game Covers from GameTDB.com for Use in Grid Mode")); | |||
| m_checkbox_show_debugging_ui = new QCheckBox(tr("Show Debugging UI")); | |||
| m_checkbox_disable_screensaver = new QCheckBox(tr("Inhibit Screensaver While Running")); | |||
There was a problem hiding this comment.
This needs to be more explicit about when power savings will be inhibited. So, I'd prefer "Inhibit Screensaver While a Game is Running". Admittedly pausing isn't "running" and it still inhibits it, but you said in IRC that you'll be fixing that, so that's fine, imo.
Also I don't really like "screensaver" since, who uses screensavers these days? But since going into standby is already inhibited and this is not related, saying "inhibits power saving" doesn't work, and screensaver is a known hack for referencing the display turning itself off, so, eeehhh.
There was a problem hiding this comment.
Perhaps "Inhibit sleep mode during emulation"
There was a problem hiding this comment.
I do like "During Emulation" better than "While a Game is Running".
|
What's the status of this PR? |
|
Does everyone like May's suggested: "Inhibit Screensaver While a Game is Running"? |
|
Personally I'm fine with it -- the only change to the wording that needed to be done is to clarify that the option only applies while a game is running. |
|
Ping ^^ |
|
Just had to Google for what to edit in the .ini so this option is much needed. Thanks |
jordan-woyak
force-pushed
the
expose-disable-ss
branch
from
535220f
to
660b60e
Compare
|
If you change the setting while a game is running, does the change apply without having to restart? |
|
@JosJuice did you try it? If so what did you see? |
|
@JosJuice |
jordan-woyak
force-pushed
the
expose-disable-ss
branch
from
660b60e
to
0c2e110
Compare
jordan-woyak
force-pushed
the
expose-disable-ss
branch
from
0c2e110
to
50ec747
Compare
"Inhibit Screensaver During Emulation"
