Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Expose "DisableScreenSaver" in the UI and default it to true. #8613

Open
wants to merge 2 commits into
base: master
from

Conversation

@jordan-woyak
Copy link
Member

jordan-woyak commented Feb 8, 2020

"Inhibit Screensaver While Running"
image

Copy link
Contributor

iwubcode left a comment

Code LGTM. Untested. Unsure about text in UI.

@Tilka

This comment has been minimized.

Copy link
Member

Tilka commented Feb 9, 2020

The "while running" makes it sound like the screensaver is only inhibited while a game is running. This is actually the case.

@MayImilae

This comment has been minimized.

Copy link
Contributor

MayImilae commented Feb 9, 2020

I assume this also inhibits power saving modes such as turning off the display and sleep?

Also, does this only apply while a game is running, or always if Dolphin is running?

@Tilka

This comment has been minimized.

Copy link
Member

Tilka commented Feb 9, 2020

I assume this also inhibits power saving modes such as turning off the display and sleep?

Depends on the platform.

Also, does this only apply while a game is running, or always if Dolphin is running?

Only while a game is running. Need to clarify the wording imo.

@mbc07

This comment has been minimized.

Copy link
Contributor

mbc07 commented Feb 9, 2020

An issue that I often have on Windows 10 is that while Dolphin prevents the screen from turning off and the computer from entering sleep mode when this option is enabled, if you're playing exclusively with controllers, the Windows 10 Lock Screen will still come up after sometime, and when that happens it generally also makes Dolphin exit fullscreen mode.

Does this PR do anything to improve on that (e.g. preventing also the lock screen) or it just exposes the existing option with the existing behavior in the GUI?

@jordan-woyak

This comment has been minimized.

Copy link
Member Author

jordan-woyak commented Feb 9, 2020

@mbc07 This just exposes the existing option.

@8times9

This comment has been minimized.

Copy link
Contributor

8times9 commented Feb 10, 2020

What about a more commonly-used verb like "Prevent Screen Saver While Running"?

@@ -151,11 +152,13 @@ void InterfacePane::CreateUI()
m_checkbox_use_covers =
new QCheckBox(tr("Download Game Covers from GameTDB.com for Use in Grid Mode"));
m_checkbox_show_debugging_ui = new QCheckBox(tr("Show Debugging UI"));
m_checkbox_disable_screensaver = new QCheckBox(tr("Inhibit Screensaver While Running"));

This comment has been minimized.

Copy link
@MayImilae

MayImilae Feb 10, 2020

Contributor

This needs to be more explicit about when power savings will be inhibited. So, I'd prefer "Inhibit Screensaver While a Game is Running". Admittedly pausing isn't "running" and it still inhibits it, but you said in IRC that you'll be fixing that, so that's fine, imo.

Also I don't really like "screensaver" since, who uses screensavers these days? But since going into standby is already inhibited and this is not related, saying "inhibits power saving" doesn't work, and screensaver is a known hack for referencing the display turning itself off, so, eeehhh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.