InputCommon/XInput: Expose battery as input and cleanups. #8614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-woyak
force-pushed
the
xinput-battery
branch
from
55288f0
to
e7400ca
Compare
Tilka
approved these changes
Feb 9, 2020
|
Just curious, what's the advantage of having battery as an input? Is this so the user can expose the battery for alternative devices? |
|
@iwubcode The only useful purpose is mapping it to the battery setting of an emulated Wii Remote. |
|
This is extremely useful now that PR #8417 got merged... |
BhaaLseN
reviewed
Feb 9, 2020
BhaaLseN
approved these changes
Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Moved things that didn't need to be in the header.
Replaced c-arrays with
std::array.Killed some
memset/cmps.Cleaned up some comments.
Marked classes as
final.