Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputCommon: Clean up creation of inputs. #8617

Merged
merged 1 commit into from Feb 10, 2020
Merged

InputCommon: Clean up creation of inputs. #8617

merged 1 commit into from Feb 10, 2020

Conversation

jordan-woyak
Copy link
Member

Greatly simplifies creation of Input objects.
Eliminates new and make_unique calls all over the place.
std::move std::string arguments.

BhaaLseN
BhaaLseN approved these changes Feb 9, 2020
View reviewed changes
Copy link
Member

@BhaaLseN BhaaLseN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems good, and that one comment is probably ignorable/deferrable (since it kinda was like that before); untested.

Source/Core/Core/HW/WiimoteEmu/WiimoteEmu.cpp Show resolved Hide resolved
@Tilka Tilka merged commit ce1bc0b into dolphin-emu:master Feb 10, 2020
@jordan-woyak jordan-woyak deleted the control-creation-cleanup branch February 10, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoetlino leoetlino leoetlino left review comments

@BhaaLseN BhaaLseN BhaaLseN approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@jordan-woyak @BhaaLseN @leoetlino @Tilka