Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputCommon: Clean up creation of inputs. #8617

Merged
merged 1 commit into from Feb 10, 2020

Conversation

@jordan-woyak
Copy link
Member

jordan-woyak commented Feb 9, 2020

Greatly simplifies creation of Input objects.
Eliminates new and make_unique calls all over the place.
std::move std::string arguments.

Copy link
Member

BhaaLseN left a comment

Code seems good, and that one comment is probably ignorable/deferrable (since it kinda was like that before); untested.

@jordan-woyak jordan-woyak force-pushed the jordan-woyak:control-creation-cleanup branch from 1671f01 to 47877ec Feb 10, 2020
@Tilka Tilka merged commit ce1bc0b into dolphin-emu:master Feb 10, 2020
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@jordan-woyak jordan-woyak deleted the jordan-woyak:control-creation-cleanup branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.