Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Qt 5.14.1 #8623

Merged
merged 1 commit into from Feb 10, 2020
Merged

Update to Qt 5.14.1 #8623

merged 1 commit into from Feb 10, 2020

Conversation

@spycrab
Copy link
Contributor

spycrab commented Feb 9, 2020

Should greatly improve HiDPI support :)

@Tilka Tilka merged commit d129fae into dolphin-emu:master Feb 10, 2020
10 checks passed
10 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@8times9

This comment has been minimized.

Copy link
Contributor

8times9 commented Feb 10, 2020

@spycrab Could dark mode now be re-enabled for the macOS client? I think the only major obstacle to dark mode (#11557) has been fixed (see here).

@mbc07

This comment has been minimized.

Copy link
Contributor

mbc07 commented Feb 10, 2020

This seems to be causing issues with Windows 7, accordingly to this forum thread...

@spycrab

This comment has been minimized.

Copy link
Contributor Author

spycrab commented Feb 10, 2020

This seems to be causing issues with Windows 7, accordingly to this forum thread...

qwave is entirely unrelated to Qt

@spycrab spycrab deleted the spycrab:qt_5.14.1 branch Feb 10, 2020
@spycrab

This comment has been minimized.

Copy link
Contributor Author

spycrab commented Feb 10, 2020

@spycrab Could dark mode now be re-enabled for the macOS client? I think the only major obstacle to dark mode (#11557) has been fixed (see here).

Possibly, please ping me on IRC about this, as it's very much unrelated to us updating the Windows version of Qt

@BParks21

This comment has been minimized.

Copy link

BParks21 commented Feb 17, 2020

@spycrab This is causing delay in the appearance of context menus in the game list window. For example when you right click on a game in the game list. Going back to 5.0-11653 the delay is gone.

@spycrab

This comment has been minimized.

Copy link
Contributor Author

spycrab commented Feb 17, 2020

@BParks21 I can't reproduce this bug on Windows. Please file a proper bug report in our bug tracker.

@BParks21

This comment has been minimized.

Copy link

BParks21 commented Feb 17, 2020

@spycrab I've put it on the bug tracker. Are you on Windows 7 or 10. Also what build?

@JMC47

This comment has been minimized.

Copy link
Contributor

JMC47 commented Feb 17, 2020

Just note: regardless of any regression with a delay, I'd be highly against reverting this as having hidpi actually work is nice...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.