Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Re-enable Dark Mode support #8640

Merged
merged 1 commit into from Feb 26, 2020
Merged

Conversation

spycrab
Copy link
Contributor

@spycrab spycrab commented Feb 23, 2020

The Qt version we use now should support Dark Mode properly.

@8times9
Copy link
Contributor

8times9 commented Feb 23, 2020

image
The toolbar text now displays correctly in dark mode

@spycrab
Copy link
Contributor Author

spycrab commented Feb 23, 2020

@8times9 Does the rest of the interface look okay too? (Especially TAS and the Controller config Windows for Wiimotes / Gamecube Controllers)

@JosJuice
Copy link
Member

This only affects macOS, right?

@spycrab
Copy link
Contributor Author

spycrab commented Feb 23, 2020

Yes

@MayImilae
Copy link
Contributor

Here are a bunch of screenshots!

pr8640-Screenshots.zip

So two main issues I spotted. The C stick is black against dark grey, with only a little tiny bit of yellow peeking through. That's not great. For all other joysticks, the calibration bounds for the joystick, the dashed lines, are black against dark grey as well, and nearly invisible. Other than those two things, everything seems good.

Screen Shot 2020-02-23 at 03 43 49

@spycrab
Copy link
Contributor Author

spycrab commented Feb 23, 2020

@MayImilae It seems like that code already uses palettes instead of hard coded colors, so fixing this will be a bit more difficult. Would you prefer this PR be on hold until we fix that or should we go ahead and merge it anyway?

@MayImilae
Copy link
Contributor

I believe billiard is already looking into the indicators? Maybe ask him, he may already have it fixed in a pr.

@spycrab
Copy link
Contributor Author

spycrab commented Feb 26, 2020

I checked myself on Catalina. Contrast looks good now.

@spycrab spycrab merged commit 2a18e12 into dolphin-emu:master Feb 26, 2020
@spycrab spycrab deleted the macos_dark_mode branch February 26, 2020 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants