New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt: Re-enable Dark Mode support #8640
Conversation
|
@8times9 Does the rest of the interface look okay too? (Especially TAS and the Controller config Windows for Wiimotes / Gamecube Controllers) |
|
This only affects macOS, right? |
|
Yes |
|
Here are a bunch of screenshots! So two main issues I spotted. The C stick is black against dark grey, with only a little tiny bit of yellow peeking through. That's not great. For all other joysticks, the calibration bounds for the joystick, the dashed lines, are black against dark grey as well, and nearly invisible. Other than those two things, everything seems good. |
|
@MayImilae It seems like that code already uses palettes instead of hard coded colors, so fixing this will be a bit more difficult. Would you prefer this PR be on hold until we fix that or should we go ahead and merge it anyway? |
|
I believe billiard is already looking into the indicators? Maybe ask him, he may already have it fixed in a pr. |
cc3127f
to
33e9720
Compare
33e9720
to
8233255
Compare
|
I checked myself on Catalina. Contrast looks good now. |


The Qt version we use now should support Dark Mode properly.