Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] .gitmodules: Make Externals/Qt clone shallow #8651

Merged
merged 1 commit into from Mar 16, 2020

Conversation

spycrab
Copy link
Contributor

@spycrab spycrab commented Feb 26, 2020

Instead of cloning the entire history of the submodule, only fetch the latest commit. This saves about 300M of disk space currently and will only save more in the future.

Caveats:

  • A shallow clone might be slower under some circumstances such as a very fast internet connection (Try this test)
  • If you want to change anything in the Externals you will have to unshallow the clone (realistically only about 5 people ever needed to do this)

@spycrab spycrab added the RFC Request for comments label Feb 26, 2020
Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

@leoetlino
Copy link
Member

Even with a 100Mbps connection, this saved ~15s of cloning time in addition to the substantial disk space usage reduction. I'd expect the time savings to be greater for most people considering that the average Internet connection speed is lower than 100Mbps...

@stenzek
Copy link
Contributor

stenzek commented Mar 16, 2020

Also sounds good to me.

@stenzek stenzek merged commit 3613642 into dolphin-emu:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request for comments
3 participants