Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Tweak Toolbar Text #8657

Open
wants to merge 8 commits into
base: master
from
Open

Qt: Tweak Toolbar Text #8657

wants to merge 8 commits into from

Conversation

@sonic2kk
Copy link
Contributor

sonic2kk commented Mar 1, 2020

Currently the Toolbar has some unnecessary abbreviations, which I believe are holdovers from the wxWidgets UI. Also, the text for the Settings menu says "Config", however in code this is referred to as "Settings". It is also ambiguous as the "Configuration" screen for the graphics backend shares the same name on the UI.

"FullScr", "ScrShot" and "Config" have been changed to say "Fullscreen", "Screenshot" and "Settings". The MenuBar text and Settings dialog window have also been updated to reflect the change.

Master branch:
Screenshot_20200301_235717

Pull Request:
Screenshot_20200301_235826

sonic2kk added 8 commits Feb 26, 2020
Qt: Use Builtin QKeySequence Shortcuts
Revert "Qt: Use Builtin QKeySequence Shortcuts"
Change MenuBar text from 'Configuration' to 'Settings'
@Techjar

This comment has been minimized.

Copy link
Contributor

Techjar commented Mar 2, 2020

Seems you made a bit of a mess of the commits.

@MayImilae

This comment has been minimized.

Copy link
Contributor

MayImilae commented Mar 2, 2020

So the Fullscr and ScrShot etc text was done deliberately to allow the icons to have even spacing. This was something that was debated and considered pretty carefully in the past, so please do not change it.

@sonic2kk

This comment has been minimized.

Copy link
Contributor Author

sonic2kk commented Mar 2, 2020

That seems like such an odd way to handle such a feature, but that isn't up to me. I guess I'll revert those.

@orbea

This comment has been minimized.

Copy link
Contributor

orbea commented Mar 2, 2020

Personally I think the master looks better, the length of text fits much better with the width of the icons.

@mbc07

This comment has been minimized.

Copy link
Contributor

mbc07 commented Mar 3, 2020

Honestly, having the button labels intentionally abbreviated so they have a consistent width seems a moot point. As far as I could tell, English seems to be the only language in Dolphin where some of the button labels were deliberately abbreviated to achieve a consistent width.

Those button labels are all marked as translatable strings and, in fact, I randomly changed Dolphin's language to the other translations that ships with Dolphin and as I suspected, the button width weren't consistent at all, except in eastern languages where their own, um, glyphs (is that the correct term?) actually results in button labels that actually are narrower than the button icons.

With that said, I do think "Fullscreen", "Screenshot" and "Settings" looks better, even if the button width isn't consistent anymore. This would also make the English button labels actually more consistent with the other translations that ships in Dolphin, where most don't use any abbreviation at all...

@leoetlino

This comment has been minimized.

Copy link
Member

leoetlino commented Mar 15, 2020

Could you rebase this and get rid of the unncessary commits (e.g. the merge commits) with squashs/fixups please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.