RSO: Auto-detect RSO location in RAM #8668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Mar 12, 2020
|
Commit message for the second commit should also provide some form of description, rationale, or some form of explanation. Currently it can just be interpreted as "Implemented thing", which isn't as helpful of a description as it could be. |
BhaaLseN
reviewed
Mar 13, 2020
sepalani
force-pushed
the
rso-autodetect
branch
2 times, most recently
from
bb29455
to
0e6f1c4
Compare
sepalani
force-pushed
the
rso-autodetect
branch
from
0e6f1c4
to
3622ee0
Compare
|
All of the above comments are addressed. I also modified the code a bit to add RSO module names to the dropdown. |
leoetlino
reviewed
Mar 18, 2020
leoetlino
reviewed
Mar 18, 2020
sepalani
force-pushed
the
rso-autodetect
branch
from
3622ee0
to
92d03eb
Compare
|
@leoetlino Done. |
lioncash
reviewed
Mar 21, 2020
Add auto-detection option
sepalani
force-pushed
the
rso-autodetect
branch
from
92d03eb
to
9ec5391
Compare
|
@lioncash Fixed. |
leoetlino
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR adds an auto-detect features to the Generate Symbols from > RSO modules.
Ready to be reviewed.