BTReal: Improve error handling for device opening #8671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
force-pushed
the
bt-passthrough-error
branch
from
c46e6e5
to
d6a8802
Compare
iwubcode
reviewed
Mar 15, 2020
leoetlino
force-pushed
the
bt-passthrough-error
branch
from
d6a8802
to
aca48d2
Compare
iwubcode
approved these changes
Mar 15, 2020
JosJuice
reviewed
Mar 15, 2020
leoetlino
force-pushed
the
bt-passthrough-error
branch
from
aca48d2
to
dd47e5a
Compare
This commit attempts to improve error handling for device opening by reducing panic alert spam when opening one or several devices fails. Currently, Dolphin shows a panic alert for every device that we fail to open, and another panic alert at the end if no usable device was found. That is certainly a bit excessive -- we should only keep the very last panic alert (the one that is shown if everything fails) and we can just put the error for the last device open operation there. This also changes the PanicAlert to a CriticalAlert to ensure the message is visible even if the user has disabled regular panic alerts. The message has also been reworded and should hopefully be clearer.
leoetlino
force-pushed
the
bt-passthrough-error
branch
from
dd47e5a
to
73e7f2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This commit attempts to improve error handling for device opening by
reducing panic alert spam when opening one or several devices fails.
Currently, Dolphin shows a panic alert for every device that we fail
to open, and another panic alert at the end if no usable device was
found. That is certainly a bit excessive -- we should only keep the
very last panic alert (the one that is shown if everything fails)
and we can just put the error for the last device open operation there.
This also changes the PanicAlert to a CriticalAlert to ensure the
message is visible even if the user has disabled regular panic alerts.
The message has also been reworded and should hopefully be clearer.