Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup warnings of -Wmissing-declarations #8696

Merged
merged 1 commit into from Apr 27, 2020

Conversation

howard0su
Copy link
Contributor

Add static to the functions which is not intentionally
export to big scope.

Copy link
Contributor

@stenzek stenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the lint issues are fixed. We could probably move the surrounding classes into an anonymous namespace too since they're not used outside, but happy for that to be a separate change.

Format fix:

!!! Source/Core/VideoBackends/Vulkan/ShaderCompiler.cpp not compliant to coding style, here is the fix:
--- Source/Core/VideoBackends/Vulkan/ShaderCompiler.cpp	2020-03-23 18:18:38.764021444 +0000
+++ -	2020-03-23 18:18:41.440714291 +0000
@@ -107,8 +107,10 @@
   #define SUBGROUP_MAX(value) value = subgroupMax(value)
 )";
 
-static std::optional<SPIRVCodeVector> CompileShaderToSPV(EShLanguage stage, const char* stage_filename,
-                                                  std::string_view source, std::string_view header)
+static std::optional<SPIRVCodeVector> CompileShaderToSPV(EShLanguage stage,
+                                                         const char* stage_filename,
+                                                         std::string_view source,
+                                                         std::string_view header)
 {
   if (!InitializeGlslang())
     return std::nullopt;

Add static to the functions which is not intentionally
export to big scope.
@leoetlino leoetlino merged commit 9d44af4 into dolphin-emu:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants