Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SettingsHandler: Don't output null bytes #8704

Merged
merged 1 commit into from Apr 28, 2020
Merged

SettingsHandler: Don't output null bytes #8704

merged 1 commit into from Apr 28, 2020
+29 −18

Conversation

JosJuice
Copy link
Member

@JosJuice
Copy link
Member Author

We might want to revert PR #8680 at some point, but I would like to wait a little with doing that to let people migrate any null-containing setting.txt they have.

@Leseratte10
Copy link
Contributor

Leseratte10 commented Mar 24, 2020 •
edited

I just built a version of Dolphin with this PR included, and all four NANDs I tested worked properly. When playing out-of-region games I needed to enable the "Allow Mismatched Region Settings" setting, but when that was enabled, all the identifiers were identical to these from the NAND dump, including the serial number, no matter which region the game was from. So it looks like this PR completely fixes the issue, at least for all the NANDs I have available to test.

@Leseratte10
Copy link
Contributor

Just poking this PR again, is there a chance to get this merged soon?

@leoetlino leoetlino merged commit 8f578fd into dolphin-emu:master Apr 28, 2020
@JosJuice JosJuice deleted the setting-txt-output-null branch April 28, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leseratte10 Leseratte10 Leseratte10 left review comments

@leoetlino leoetlino leoetlino approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@JosJuice @Leseratte10 @leoetlino