Android: Split General settings #8709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
approved these changes
Mar 30, 2020
|
Can we get this merged too? This change is needed for some future PRs. Nobody has complained about the design change and it's easily reversible if somebody really doesn't like it. Also mentioning @JMC47 since this has already been approved. |
|
Merge reminder? |
|
Is there any reason why this isn't getting merged? It's needed for future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Android: Split General settings: General settings was a merge of a few submenus. I split them up to match the Win build, which should make users do less searching.
Android: Reduce Submenu height by 25 percent: This will make users do less scrolling as more submenus are added. I also dropped submenu descriptions, as they were only used with the Stereoscopy submenu. I think unified Dolphin settings outweigh a definition of stereoscopy.
Screenshot for @MayImilae
