Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Insert SD Card default value to true #8711

Merged
merged 1 commit into from Apr 16, 2020
Merged

Conversation

Ebola16
Copy link
Member

@Ebola16 Ebola16 commented Mar 30, 2020

Enabling the SD card is useful for loading / saving data for games such as Super Smash Bros. Brawl. I assume most users won't encounter any problems with this setting enabled. Was there a reason why the default was set to false? Also, the virtual SD card is created regardless of this setting.

@mbc07
Copy link
Contributor

mbc07 commented Mar 30, 2020

Also, the virtual SD card is created regardless of this setting.

I'm 95% sure Dolphin only generates sd.raw after you enable the option and boot a Wii game or if you enable the option while a Wii game is already running. Unless something changed, that has been the behavior since the feature was introduced, basically...

@Ebola16
Copy link
Member Author

Ebola16 commented Mar 30, 2020

I'm 95% sure Dolphin only generates sd.raw after you enable the option and boot a Wii game or if you enable the option while a Wii game is already running. Unless something changed, that has been the behavior since the feature was introduced, basically...

Just checked again on 5.0-11824. Indeed the virtual SD card is created regardless of the Insert SD Card setting.

@JosJuice
Copy link
Member

Yes, it does seem like an SD card file gets created by IOS HLE as soon as the emulated software makes any use of SD card functionality, regardless of the setting. I don't know if this is the desired behavior, though.

@JMC47
Copy link
Contributor

JMC47 commented Apr 16, 2020

I don't see any reason not to let it be plugged in if it's getting created.

@JMC47 JMC47 merged commit 55ed980 into dolphin-emu:master Apr 16, 2020
@Ebola16 Ebola16 deleted the SDDE branch April 16, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants