Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DolphinQt: Run tasks that use progress dialogs on separate threads #8714

Merged
merged 2 commits into from Apr 22, 2020
Merged

DolphinQt: Run tasks that use progress dialogs on separate threads #8714

merged 2 commits into from Apr 22, 2020

Conversation

JosJuice
Copy link
Member

No description provided.

@JosJuice
Copy link
Member Author

Apparently this not only makes the GUI more responsive (which was my intention with this PR) but also fixes a deadlock that was likely to happen if VolumeVerifier got a panic alert on one of its helper threads (most easily triggered by attempting to verify a correctly signed vWii WAD).

@JosJuice JosJuice mentioned this pull request Apr 19, 2020
Merged
@JMC47 JMC47 merged commit a5bd263 into dolphin-emu:master Apr 22, 2020
@JosJuice JosJuice deleted the progress-dialog-thread branch April 22, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pokechu22 Pokechu22 Pokechu22 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@JosJuice @Pokechu22 @JMC47