Delete properties dialog on close #8716
Conversation
| @@ -32,6 +32,7 @@ PropertiesDialog::PropertiesDialog(QWidget* parent, const UICommon::GameFile& ga | |||
| QString::fromStdString(game.GetGameID()), | |||
| QString::fromStdString(game.GetLongName()))); | |||
| setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint); | |||
| setAttribute(Qt::WA_DeleteOnClose, true); | |||
There was a problem hiding this comment.
This should probably have a comment accompanying it explaining why this behavior is needed.
There was a problem hiding this comment.
Alternatively, maybe the code would be clear enough on its own without needing a comment if we move this line to where the PropertiesDialog gets allocated? That is how every other usage of Qt::WA_DeleteOnClose in Dolphin seems to be done.
There was a problem hiding this comment.
Added the comment, but I think what JosJuice mentions is better; I'll do that now.
There was a problem hiding this comment.
Changed the comment and moved it to the allocation point. (For reference, the previous comment was The properties dialog is not re-used, and maintains a lock on the game file until it's deleted, preventing the file from being moved or deleted.)
Pokechu22
force-pushed
the
properties-leak
branch
from
110a7cb
to
03eb887
Compare
Fixes the game file being locked until Dolphin closes.
Pokechu22
force-pushed
the
properties-leak
branch
from
03eb887
to
e11a2bd
Compare
Fixes the game file being locked until Dolphin closes. The properties dialog technically didn't leak before this, since Qt will close it when its parent window closes, but that only happens when dolphin itself exits and that's way longer than it needs to be. (See also: #8088 (comment))