Android TV: Fix crash when long pressing a game #8718
Merged
+29
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
force-pushed
the
android-tv-long-press
branch
from
b9bea61
to
2afbe7d
Compare
Also fixes the same crash when accessing the game details (which only can be accessed after long pressing a game). The problem was that we were not using a theme that had an AppCompat theme as a parent. Unfortunately, the game details dialog uses white on white on Android TV, and I don't know how to fix this in a clean way.
For consistency, and in case I missed any cases where not specifing a theme could lead to a crash on Android TV.
JosJuice
force-pushed
the
android-tv-long-press
branch
from
2afbe7d
to
163b176
Compare
|
Hopefully this will get merged soon, even if it does have white on white dialogue currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Also fixes the same crash when accessing the game details (which only can be accessed after long pressing a game). The problem was that we were not using a theme that had an AppCompat theme as a parent.
After fixing the crashes, I discovered that the game details dialog unfortunately uses white on white on Android TV, and I don't know how to fix this in a clean way. But I guess that can be left for another PR?