AudioPane: Do not enable DPL II quality slider with HLE audio on init #8719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe linked to bug #12036 |
|
Indeed it is, although it looks like in this case the user actually observed this wrong behaviour and expected it to work differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR is a de facto follow up to #8664, since there was one more case where DPL II audio quality slider was enabled when it shouldn't be - if Audio panel was opened with HLE audio selected and DPL II checkbox checked (as a "leftover" from using LLE audio, most likely), slider would be enabled while the checkbox itself was disabled. Now it's back in sync, as only this one code path seemed to be out of sync (for this reason candidate for refactor maybe?)