Android: Use touch emulation of IR by default

[JosJuice]

While having motion control emulation of IR enabled by default makes sense in situations like using a DualShock 4 on a PC, Android has the additional option of touch emulation of IR which seems to be better liked, and the default value which was chosen with PC in mind was carried over to Android without any particular consideration. This change disables motion control emulation of IR by default on Android only.

[rlnilsen]

Perhaps there is a reason you did it this way, but it seems more readable to leave the CanBeDisabled enum untouched and in stead initialize the ControlGroup's existing enabled member through an additional constructor argument, like this:

ControlGroup(std::string name, GroupType type = GroupType::Other, 
             CanBeDisabled can_be_disabled = CanBeDisabled::No, 
             EnabledByDefault enabled_by_default = EnabledByDefault::Yes);

edit: or

             Enabled enabled = Enabled::Yes);

[JosJuice]

Your suggestion works too, though I think it's more wordy. Does anyone else have an opinion on this?

[leoetlino]

I think I'd keep the one-enum solution, but rename CanBeDisabled to something like DefaultState, so that the options become DefaultState::Enabled, DefaultState::Disabled and DefaultState::AlwaysEnabled, which is more readable IMO. Using two enums has the drawback of making it possible to specify a nonsensical combination like (CanBeDisabled::No, EnabledByDefault::No).

[JosJuice]

I've made it use @leoetlino's suggestion.