Adjust s_DIMAR/s_DILENGTH behavior (fixes Baten Kaitos music) #8733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugs.dolphin-emu.org/issues/11997 The problem seemed to be that s_DILENGTH would get set to 0 at times when it shouldn't. Simply not changing it in case of NoReply or DTK seems to fix the problem. However, we can actually go one step further in accuracy and use data.size() to change s_DIMAR and s_DILENGTH as partial reads (NoReply commands) complete, instead of jumping directly to 0 when the whole read completes.
|
Can confirm that this fixes the music issue in Baten Kaitos. |
BhaaLseN
reviewed
Apr 10, 2020
|
|
||
| u32 transfer_size = 0; | ||
| if (reply_type == ReplyType::NoReply) | ||
| transfer_size = static_cast<u32>(data.size()); |
There was a problem hiding this comment.
Can this value ever exceed the current value of s_DILENGTH (making it potentially negative after the subtraction down there)?
There was a problem hiding this comment.
Only if the emulated software overwrites s_DILENGTH in the middle of a read, which doesn't make much sense. I'm not sure what happens on hardware if you do that.
BhaaLseN
approved these changes
Apr 10, 2020
|
|
||
| u32 transfer_size = 0; | ||
| if (reply_type == ReplyType::NoReply) | ||
| transfer_size = static_cast<u32>(data.size()); |
Pokechu22
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.dolphin-emu.org/issues/11997
The problem seemed to be that
s_DILENGTHwould get set to 0 at times when it shouldn't. Simply not changing it in case ofNoReplyorDTKseems to fix the problem. However, we can actually go one step further in accuracy and usedata.size()to changes_DIMARands_DILENGTHas partial reads (NoReplycommands) complete, instead of jumping directly to 0 when the whole read completes.