Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Reload Wii Remote settings upon saving them #8735

Merged
merged 1 commit into from Apr 17, 2020

Conversation

Ebola16
Copy link
Member

@Ebola16 Ebola16 commented Apr 10, 2020

@JosJuice
Copy link
Member

It seems a bit fishy to me that we call UICommon::Init twice, which is a function that does quite a lot of things, some of which maybe shouldn't be done twice... It would be better to just reload the controller settings, if that is possible (I haven't looked into it yet).

@Ebola16
Copy link
Member Author

Ebola16 commented Apr 10, 2020

@JosJuice I think I found a better way.

@Ebola16 Ebola16 changed the title Android: Reinitialize UICommon elements on emulation start Android: Reload Wii Remote settings on emulation start Apr 10, 2020
@JosJuice
Copy link
Member

Yes, that looks better.

Just one more thing to consider: Is it better to do this when starting emulation or right after saving the settings? I did the latter for the "normal" settings, and I guess it would make sense to use the same approach for both so there's no inconsistency, though I'm not sure if there are any particular reasons why my approach would be better.

@Ebola16
Copy link
Member Author

Ebola16 commented Apr 10, 2020

@JosJuice changed to your suggestion. Let's run less code at emulation start.

@Ebola16 Ebola16 changed the title Android: Reload Wii Remote settings on emulation start Android: Reload Wii Remote settings upon saving them Apr 10, 2020
@JosJuice JosJuice merged commit cf67b20 into dolphin-emu:master Apr 17, 2020
@Ebola16 Ebola16 deleted the INIT branch April 17, 2020 09:43
@GjGamesBr
Copy link

Hey Ebola16
Can You add a Multimapping function on dolphin emulator for android plzzz, so the people can add one button for 2 or more things
this will help on guitar hero & rock band series because mapping 5 buttons on strum and mapping these 5 buttons on the color buttons, will make the tap notes and will become no necessary strum

@Ebola16
Copy link
Member Author

Ebola16 commented Jun 22, 2020

@GjGamesBr If your feature request doesn't already exist on our issue tracker (https://bugs.dolphin-emu.org/projects/emulator/issues), can you file it? I haven't worked with that part of the code yet and I don't own those games so another dev might be able to better help you there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants