New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Reload Wii Remote settings upon saving them #8735
Conversation
|
It seems a bit fishy to me that we call |
|
@JosJuice I think I found a better way. |
|
Yes, that looks better. Just one more thing to consider: Is it better to do this when starting emulation or right after saving the settings? I did the latter for the "normal" settings, and I guess it would make sense to use the same approach for both so there's no inconsistency, though I'm not sure if there are any particular reasons why my approach would be better. |
|
@JosJuice changed to your suggestion. Let's run less code at emulation start. |
|
Hey Ebola16 |
|
@GjGamesBr If your feature request doesn't already exist on our issue tracker (https://bugs.dolphin-emu.org/projects/emulator/issues), can you file it? I haven't worked with that part of the code yet and I don't own those games so another dev might be able to better help you there. |
Fixes https://bugs.dolphin-emu.org/issues/12043.
@JosJuice thanks for the help.